[Skiboot] [PATCH 1/2] hdata: Make out-of-range idata print at PR_DEBUG
Gavin Shan
gwshan at linux.vnet.ibm.com
Fri May 26 16:44:55 AEST 2017
On Fri, May 26, 2017 at 04:28:38PM +1000, Oliver O'Halloran wrote:
>Some fields just aren't populated on some systems.
>
>Signed-off-by: Oliver O'Halloran <oohall at gmail.com>
Reviewed-by: Gavin Shan <gwshan at linux.vnet.ibm.com>
>---
> hdata/hdif.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/hdata/hdif.c b/hdata/hdif.c
>index dd5e12285f32..b616a331a0bc 100644
>--- a/hdata/hdif.c
>+++ b/hdata/hdif.c
>@@ -30,8 +30,8 @@ const void *HDIF_get_idata(const struct HDIF_common_hdr *hdif, unsigned int di,
> }
>
> if (di >= be16_to_cpu(hdr->idptr_count)) {
>- prerror("HDIF: idata index out of range !\n");
>- backtrace();
>+ prlog(PR_DEBUG, "HDIF: idata %d out of range for %.6s!\n",
>+ di, hdr->id);
Maybe it deserves a PR_WARNING?
> return NULL;
> }
>
Cheers,
Gavin
More information about the Skiboot
mailing list