[Skiboot] [PATCH RFC 08/12] opal-prd: Add support for variable-sized messages

[Jeremy Kerr]

Hi Vasant,

>> This change provides the facility to invoke HBRT's reset_pm_complex, in
> 
> So is pm_complete replacement to occ_reset?

Yes, Dan's reply has details :)

>> +static int pm_complex_reset(uint64_t chip)
>> +{
>> +    int rc;
>> +
>> +    if (hservice_runtime->reset_pm_complex(chip)) {
> 
> if (hservice_runtime->reset_pm_complex) { ?

Ah, that would have been a nasty one to debug. Thanks, fixed.

> 
>> -    if (!strcmp(str, "occ")) {
>> +    if (!strcmp(str, "occ") || !strcmp(str, "pm-complex")) {
> 
> Help says only reset option is supported. But this will enable other
> options like enable, disable.

Yep, that's somewhat intentional at the moment; while enable & disable
would work, I don't want to advertise that as such at the moment, as we
don't call into the pm_complex equivalents yet.

Cheers,


Jeremy