[Skiboot] [PATCH RFC 10/12] opal-prd: Add firmware_request & firmware_notify implementations

Jeremy Kerr jk at ozlabs.org
Fri May 26 09:22:10 AEST 2017


Hi Vasant,

>> +        item = malloc(sizeof(*item) + size);
> 
> Validate malloc return value.

I'm not always convinced that this is worthwhile, but I've added
checking here anyway :)

>> +    OPAL_PRD_MSG_TYPE_FIRMWARE_REQUEST, /* HBRT --> OPAL */
>> +    OPAL_PRD_MSG_TYPE_FIRMWARE_RESPONSE, /* HBRT <-- HBRT */
> 
> HBRT <-- OPAL
> 
>> +    OPAL_PRD_MSG_TYPE_FIRMWARE_NOTIFY, /* HBRT <-- HBRT */
> 
> ditto.

Thanks, fixed.


Jeremy


More information about the Skiboot mailing list