[Skiboot] [PATCH RFC 07/12] opal-prd: use get_ipoll_mask() callback

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Thu May 25 21:49:01 AEST 2017


On 05/25/2017 12:35 PM, Jeremy Kerr wrote:
> This change hooks-up the get_ipoll_mask callback, and use a
> HBRT-provided mask if it's present.

.../...

>  void hservice_puts(const char *str)
>  {
> @@ -1515,6 +1516,13 @@ static int run_attn_loop(struct opal_prd_ctx *ctx)
>  		}
>  	}
>
> +	if (hservice_runtime->get_ipoll_events) {
> +		pr_debug("HBRT: calling get_ipoll_events");
> +		opal_prd_ipoll = call_get_ipoll_events();

So if get_ipoll_events fails then we endup passing same value. But looking into 
interface definition, I don't see a way to validate the output. May be validate 
for negative values?

-Vasant



More information about the Skiboot mailing list