[Skiboot] [PATCH] hdata: Check the Host I2C devices array version

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Thu May 25 16:46:10 AEST 2017


On 05/24/2017 01:39 PM, Oliver O'Halloran wrote:
> Currently this is not populated on FSP machines which causes some
> obnoxious errors to appear in the boot log. We also only want to
> parse version 1 of this structure since future versions will completely

Latest HDAT spec says 0x02 for P9.

> change the array item format.
>
> Cc: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
> Signed-off-by: Oliver O'Halloran <oohall at gmail.com>
> ---
>  hdata/i2c.c | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
>
> diff --git a/hdata/i2c.c b/hdata/i2c.c
> index f5c5bafe758b..4c3f920e2fda 100644
> --- a/hdata/i2c.c
> +++ b/hdata/i2c.c
> @@ -149,6 +149,11 @@ static bool is_zeros(const void *p, size_t size)
>  	return true;
>  }
>
> +struct host_i2c_hdr {
> +	const struct HDIF_array_hdr hdr;
> +	__be32 version;

May be we should define macro for each version instead of hardcoding below.

-Vasant



More information about the Skiboot mailing list