[Skiboot] [PATCH] activate shared PCI slot support on witherspoon

Benjamin Herrenschmidt benh at kernel.crashing.org
Tue May 23 22:06:41 AEST 2017


On Tue, 2017-05-23 at 11:38 +0200, Frederic Barrat wrote:
> Mikey, Ben, thanks for the review, will send v2 shortly.
> 
> 
> Le 23/05/2017 à 02:33, Michael Neuling a écrit :
> > -	pci_register_phb(&p->phb, p->chip_id * 6 + p->index); //6 PHBs per
> > chip?
> 
> Ben: do you remember the reason for the question mark? I've only seen 
> doc mentioning 6 PHBs per chip.

We should move this logic (along with your reverse function) into some
kind of helper pair using a symbol instead of "6" along with a comment,
we are using 6 because this is the max# of PHBs per chip on P9.

Cheers,
Ben.



More information about the Skiboot mailing list