[Skiboot] [PATCH] libstb: Fix build in OpenSSL 1.1

Stewart Smith stewart at linux.vnet.ibm.com
Fri May 19 11:37:53 AEST 2017


Russell Currey <ruscur at russell.cc> writes:
> On Thu, 2017-05-18 at 16:45 +1000, Stewart Smith wrote:
>> Russell Currey <ruscur at russell.cc> writes:
>> > OpenSSL has some API changes which causes a build break in libstb.
>> > Specifically, directly accessing some members of a signature now requires
>> > using
>> > a helper.
>> > 
>> > This fixes things in OpenSSL 1.1 and has no effect on OpenSSL 1.0.
>> > 
>> > The build failure was as follows:
>> > 
>> > [ HOSTCC ] libstb/create-container.c
>> > In file included from /usr/include/openssl/asn1.h:24:0,
>> >                  from /usr/include/openssl/ec.h:30,
>> >                  from libstb/create-container.c:36:
>> > libstb/create-container.c: In function ‘getSigRaw’:
>> > libstb/create-container.c:104:31: error: dereferencing pointer to incomplete
>> > 				  type ‘ECDSA_SIG {aka struct ECDSA_SIG_st}’
>> >   rlen = BN_num_bytes(signature->r);
>> >                                ^
>> > 
>> > Signed-off-by: Russell Currey <ruscur at russell.cc>
>> 
>> Sweet - this fixes the last build failure on fedora-rawhide in travis!
>
> The joys of being an Arch user, I hit this before everyone else :)

Feel free to add arch to the platforms build tested in travis.

Catching these things early is why I added rawhide :)


-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list