[Skiboot] [PATCH V3 3/5] capi: Enable capi mode

Stewart Smith stewart at linux.vnet.ibm.com
Fri May 12 13:52:26 AEST 2017


Alistair Popple <alistair at popple.id.au> writes:
>> It should be a separate patch on its own, to make it more visible.
>> We had discussed it, but for the record: we need to limit the workaround
>> to DD1.x and DD2.0, as it will be fixed with DD2.1.
>> Stewart can comment, but it looks like it can be tested with
>> chip->ec_level. From chip.h, it's encoded like:
>> 	/* 0xMm (DD1.0 = 0x10) */
>> Also, I think we should drop the test on P9_CUMULUS, since we don't know
>> how things will look like there.
>
> Rather than detecting chip ec_levels I think we should read a property
> from the device-tree that gets added when creating the nmmu node on
> the affected parts. I guess it doesn't make a huge difference but it
> does mean the host OS can easily tell if it's been disabled or not.

That makes sense.

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list