[Skiboot] [PATCH] head.S: store all of LR and CTR

Stewart Smith stewart at linux.vnet.ibm.com
Mon May 8 14:37:31 AEST 2017


Benjamin Herrenschmidt <benh at kernel.crashing.org> writes:

> On Fri, 2017-05-05 at 16:03 +1000, Michael Neuling wrote:
>> > @@ -198,8 +198,8 @@ _exception:
>> >       mflr    %r6
>> >       stw     %r3,STACK_CR(%r1)
>> >       stw     %r4,STACK_XER(%r1)
>> > -     stw     %r5,STACK_CTR(%r1)
>> > -     stw     %r5,STACK_LR(%r1)
>> > +     std     %r5,STACK_CTR(%r1)
>> > +     std     %r5,STACK_LR(%r1)
>
> You meant %r6 ?

Well, it appears that bug has always been there.

I'll merge something like this:

diff --git a/asm/head.S b/asm/head.S
index b10fbb554657..a2dcb8cddc85 100644
--- a/asm/head.S
+++ b/asm/head.S
@@ -199,7 +199,7 @@ _exception:
 	stw	%r3,STACK_CR(%r1)
 	stw	%r4,STACK_XER(%r1)
 	std	%r5,STACK_CTR(%r1)
-	std	%r5,STACK_LR(%r1)
+	std	%r6,STACK_LR(%r1)
 	mfspr	%r3,SPR_SRR0
 	mfspr	%r4,SPR_SRR1
 	mfspr	%r5,SPR_HSRR0



-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list