[Skiboot] [PATCH 3/5] xscom: Harden indirect writes

Michael Neuling mikey at neuling.org
Thu Mar 23 16:10:23 AEDT 2017


> > +	/* Only 16 bit data with indirect */
> > +	if (val & ~(XSCOM_ADDR_IND_ADDR))
> > +		return OPAL_PARAMETER;
> 
> This is confusing. Shouldn't it be using XSCOM_ADDR_IND_DATA instead ?

Oops, yes, my bad....

Mikey


More information about the Skiboot mailing list