> > + /* Only 16 bit data with indirect */ > > + if (val & ~(XSCOM_ADDR_IND_ADDR)) > > + return OPAL_PARAMETER; > > This is confusing. Shouldn't it be using XSCOM_ADDR_IND_DATA instead ? Oops, yes, my bad.... Mikey