[Skiboot] [PATCH 4/5] xscom: Add indirect form 1 scoms

Benjamin Herrenschmidt benh at kernel.crashing.org
Thu Mar 23 08:33:54 AEDT 2017


On Wed, 2017-03-22 at 16:29 +0100, Cédric Le Goater wrote:
> > +static int xscom_indirect_write(uint32_t gcid, uint64_t pcb_addr,
> > uint64_t val)
> > +{
> > +     uint64_t form = (pcb_addr >> 60) & 1;
> 
> maybe use a helper ? 

At least use PPC_BIT definitions :)

Cheers,
Ben.



More information about the Skiboot mailing list