On Wed, 2017-03-22 at 16:29 +0100, Cédric Le Goater wrote: > > +static int xscom_indirect_write(uint32_t gcid, uint64_t pcb_addr, > > uint64_t val) > > +{ > > + uint64_t form = (pcb_addr >> 60) & 1; > > maybe use a helper ? At least use PPC_BIT definitions :) Cheers, Ben.