[Skiboot] [PATCH] mambo: No need to explicitly look for env(SKIBOOT)

Michael Ellerman mpe at ellerman.id.au
Tue Mar 21 22:32:13 AEDT 2017

We don't need to explicitly check for the SKIBOOT environment variable,
the existing code that does:

  mconfig boot_image SKIBOOT ../../skiboot.lid

Will do that for us, using the content of SKIBOOT if it's set, otherwise
falling back to ../../skiboot.lid.

Signed-off-by: Michael Ellerman <mpe at ellerman.id.au>
 external/mambo/skiboot.tcl | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/external/mambo/skiboot.tcl b/external/mambo/skiboot.tcl
index 8ed0257d4f7f..35a8e37b0dd6 100644
--- a/external/mambo/skiboot.tcl
+++ b/external/mambo/skiboot.tcl
@@ -18,9 +18,6 @@ mconfig stop_on_ill MAMBO_STOP_ON_ILL false
 # Location of application binary to load
 mconfig boot_image SKIBOOT ../../skiboot.lid
-if { [info exists env(SKIBOOT)] } {
-    mconfig boot_image SKIBOOT env(SKIBOOT)
 # Boot: Memory location to load boot_image, for binary or vmlinux
 mconfig boot_load MAMBO_BOOT_LOAD 0x30000000

More information about the Skiboot mailing list