[Skiboot] [PATCH v3 2/4] Move P8 timer code to separate file

Benjamin Herrenschmidt benh at kernel.crashing.org
Tue Mar 14 17:03:31 AEDT 2017

On Tue, 2017-03-14 at 10:38 +0530, Vasant Hegde wrote:
> @Ben,
>    As you suggested, I moved P8 timer code to separate file. But now I'm 
> thinking it may be good to have single file (sbe.c) and add all SBE related code 
> their (both P8 timer code and new P9 code).
> In P8, we have used direct SCOMs for SBE timer. But from P9 onwards we are 
> getting MBOX messages for SBE operations. So we can have something like below
> void sbe_timer_init(void)
> {
>         if (proc_gen == proc_gen_p8)
>                 p8_sbe_timer();
>         else
>                 sbe_timer();
> }
> Let me know which one is better.

What would you win by having a single file other than more clutter ?

I prefer keeping them separate as they have strictly nothing in common.


More information about the Skiboot mailing list