[Skiboot] [RFC] occ: Add support for OCC inband sensors

Andrew Jeffery andrew at aj.id.au
Fri Mar 10 10:32:50 AEDT 2017


On Thu, 2017-03-09 at 13:44 +0100, Cédric Le Goater wrote:
> Hello Shilpasri,
> 
> Thanks for the write up on the OCC sensors. Nice and detailed.
> 
> On the overall design, I think this is exposing too much HW details 
> to Linux. I am not sure Linux should even know about OCC or where
> the sensors are coming from. Even if this is doable, I would not 
> let the kernel loop on the OCC data to collect which sensors are
> available. What is being done under :
> 
> 	arch/powerpc/platforms/powernv/opal-occ-sensors.c
> 
> in the Linux driver should be in the firmware IHMO. 
> 
> skiboot should hide the gory details and expose in the device 
> tree sensor nodes collected from the different available sources: 
> FSP, BMC, OCC, DTS, etc. 
> 
> There is a framework in place in skiboot for that, which may be, 
> needs some tuning to add OCC support. But the good thing about it, 
> is that the Linux driver comes for free in *all* Linux distros now.

I spoke with Stewart a while back about how we should expose sensors to
Linux and we reached the same conclusions as Cedric. Lets keep the OCC
details contained in the firmware.

Cheers,

Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/skiboot/attachments/20170310/b39b58e0/attachment.sig>


More information about the Skiboot mailing list