[Skiboot] [PATCH v3 3/3] SBE: Add timer support

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Thu Mar 9 16:36:08 AEDT 2017


On 03/08/2017 05:36 PM, Benjamin Herrenschmidt wrote:
> On Wed, 2017-03-08 at 16:31 +0530, Vasant Hegde wrote:
>> SBE on P9 provides one shot programmable timer facility. We can use
>> this
>> to implement OPAL timers and hence limit the relieance on the Linux
>> heartbeat (Similar to HW timer facility provided by SLW on P8).
>
> I haven't reviewed in details yet, just a minor comment about naming...
>
> Technically it's also "SBE" on P8 :-) I'm not sure what the name of the
> little engine they use for both SBE and SLW there, so I put everything
> under "SLW".

Ah ok. I thought its SLW ;-)

>
> On P9 it's Peppy's doing both the "STOP image" (ex-SLW) and SBE job.
>
> So I think we should probably just have sbe_p8.c and sbe_p9.c both
> exporting their respective function and move the p8 one out of slw.c

Makes sense. Let me try to move P8 ones to separate file.

-Vasant



More information about the Skiboot mailing list