[Skiboot] [PATCH] opal-prd: Direct systemd to always restart opal-prd

[Ananth N Mavinakayanahalli]

On Thu, Mar 09, 2017 at 09:17:08AM +0530, Vaibhav Jain wrote:
> Hi Vaidy,
> 
> Vaidyanathan Srinivasan <svaidy at linux.vnet.ibm.com> writes:
> 
> > There should be a restart limit.  If we actually crash starting
> > opal-prd, then we will get stuck infinitely trying to start it.
> >
> > This could happen if there are events pending and actually the event
> > action is crashing prd.  We will keep getting the same attention and
> > not make any progress.
> >
> > Does systemd unit file allow a limited restart attempts?
> 
> By default systemd will ratelimit the number of times a unit is
> started via StartLimitBurst, StartLimitIntervalSec option which defaults
> to 5-times/10-sec.
> 
> Also the default RestartSec interval is 100ms. So in case of an error
> spike and default RestartSec; opal-prd may be restarted too quickly and
> will get rate limited thereby missing reported prd errors.
> 
> So I would suggest RestartSec=1 and StartLimitIntervalSec=5 so that
> opal-prd is restart after about 1 second interval without any rate
> limiting.

One second is too long a time to not run opal-prd. I would think
rate-limiting as it is, and getting to know systemd stopped trying to
restart it is a better option than to keep trying and failing.

Ananth