[Skiboot] [PATCH] opal-prd: Direct systemd to always restart opal-prd

Vaidyanathan Srinivasan svaidy at linux.vnet.ibm.com
Thu Mar 9 04:40:50 AEDT 2017


* Ananth N Mavinakayanahalli <ananth at linux.vnet.ibm.com> [2017-03-08 15:05:28]:

> Always restart the opal-prd daemon, irrespective of why it stopped.
> 
> Signed-off-by: Ananth N Mavinakayanahalli <ananth at linux.vnet.ibm.com>
> ---
> 
> V2: Add Signed-off-by
> ---
>  external/opal-prd/opal-prd.service |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/external/opal-prd/opal-prd.service b/external/opal-prd/opal-prd.service
> index 9956912..a53d8d9 100644
> --- a/external/opal-prd/opal-prd.service
> +++ b/external/opal-prd/opal-prd.service
> @@ -5,6 +5,7 @@ ConditionPathExists=/sys/firmware/devicetree/base/ibm,opal/diagnostics
>  
>  [Service]
>  ExecStart=/usr/sbin/opal-prd --pnor /dev/mtd0
> +Restart=always

There should be a restart limit.  If we actually crash starting
opal-prd, then we will get stuck infinitely trying to start it.

This could happen if there are events pending and actually the event
action is crashing prd.  We will keep getting the same attention and
not make any progress.

Does systemd unit file allow a limited restart attempts?

--Vaidy



More information about the Skiboot mailing list