[Skiboot] [PATCH] hdata: Add BMC device-tree node for P9 OpenPOWER systems

Ananth N Mavinakayanahalli ananth at linux.vnet.ibm.com
Sat Mar 4 01:42:59 AEDT 2017


On Sat, Mar 04, 2017 at 01:36:11AM +1100, Oliver O'Halloran wrote:
> On Sat, Mar 4, 2017 at 1:02 AM, Joel Stanley <joel at jms.id.au> wrote:
> > On Fri, Mar 3, 2017 at 10:18 PM, Ananth N Mavinakayanahalli
> > <ananth at linux.vnet.ibm.com> wrote:
> >> On P8 Hostboot creates the node. On P9, OPAL needs to create the node. BMC
> >> information available in HDAT's SPINFO section.
> >>
> >> Signed-off-by: Ananth N Mavinakayanahalli <ananth at linux.vnet.ibm.com>
> >> ---
> >>  hdata/fsp.c   |   17 ++++++++++++++++-
> >>  hdata/spira.h |    1 +
> >>  2 files changed, 17 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/hdata/fsp.c b/hdata/fsp.c
> >> index f44f6a9..3896dc4 100644
> >> --- a/hdata/fsp.c
> >> +++ b/hdata/fsp.c
> >> @@ -279,11 +279,26 @@ static void add_uart(const struct spss_iopath *iopath, struct dt_node *lpc)
> >>
> >>  static void bmc_create_node(const struct HDIF_common_hdr *sp)
> >
> > I know you didn't add this function, but bmc_create_node in fsp.c?
> > What happened here?
> 
> I thought it was funny. I regret nothing.

'Funny Service Processor'? :-)

May apply equally to FSP and BMC... ergo, aptly named.



More information about the Skiboot mailing list