[Skiboot] [PATCH] hdata: Add BMC device-tree node for P9 OpenPOWER systems
Ananth N Mavinakayanahalli
ananth at linux.vnet.ibm.com
Sat Mar 4 01:29:17 AEDT 2017
On Sat, Mar 04, 2017 at 12:32:04AM +1030, Joel Stanley wrote:
> On Fri, Mar 3, 2017 at 10:18 PM, Ananth N Mavinakayanahalli
> <ananth at linux.vnet.ibm.com> wrote:
> > On P8 Hostboot creates the node. On P9, OPAL needs to create the node. BMC
> > information available in HDAT's SPINFO section.
> > Signed-off-by: Ananth N Mavinakayanahalli <ananth at linux.vnet.ibm.com>
> > ---
> > hdata/fsp.c | 17 ++++++++++++++++-
> > hdata/spira.h | 1 +
> > 2 files changed, 17 insertions(+), 1 deletion(-)
> > diff --git a/hdata/fsp.c b/hdata/fsp.c
> > index f44f6a9..3896dc4 100644
> > --- a/hdata/fsp.c
> > +++ b/hdata/fsp.c
> > @@ -279,11 +279,26 @@ static void add_uart(const struct spss_iopath *iopath, struct dt_node *lpc)
> > static void bmc_create_node(const struct HDIF_common_hdr *sp)
> I know you didn't add this function, but bmc_create_node in fsp.c?
> What happened here?
Well, I guess whoever wrote the early BMC support thought it the file
name wasn't that big a deal :-)
sp.c would've been an ideal name -- that cosmetic change for some other
day, I guess.
More information about the Skiboot