[Skiboot] [PATCH] phb4: Make MMIO0 BAR 256GB big

Benjamin Herrenschmidt benh at kernel.crashing.org
Thu Mar 2 09:59:46 AEDT 2017


On Thu, 2017-03-02 at 09:54 +1100, Michael Neuling wrote:
> diff --git a/hw/phb4.c b/hw/phb4.c
> index f4b5af3916..6a2f97b8a3 100644
> --- a/hw/phb4.c
> +++ b/hw/phb4.c
> @@ -3264,7 +3264,7 @@ static void phb4_create(struct dt_node *np)
>  #define        ESB_BAR_BASE     0x000600c300000000ULL
>  #define        ESB_BAR_SIZE     0x0000000020000000ULL
>  #define        MMIO0_BAR_BASE   0x0006000000000000ULL
> -#define        MMIO0_BAR_SIZE   0x0000002000000000ULL
> +#define        MMIO0_BAR_SIZE   0x0000004000000000ULL
>  #define        MMIO1_BAR_BASE   0x000600c000000000ULL
>  #define        MMIO1_BAR_SIZE   0x0000000080000000ULL

NAK. Your MMIO0 is going to collide with MMIO1 on PHB 3 and above

Cheers,
Ben.



More information about the Skiboot mailing list