[Skiboot] [PATCH] capp: Fix hang when CAPP microcode LID is missing on FSP machine

Stewart Smith stewart at linux.vnet.ibm.com
Mon Jun 26 17:10:54 AEST 2017


Benjamin Herrenschmidt <benh at kernel.crashing.org> writes:
> When the LID is absent, we fail early with an error from
> start_preload_resource. In that case, capp_ucode_info.load_result
> isn't set properly causing a subsequent capp_lid_download() to
> call wait_for_resource_loaded() on something that isn't being
> loaded, thus hanging.
>
> Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>
> ---
>  hw/capp.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

This bug has probably existed forever... and it doesn't help that my ZZ
system isn't exactly in the mood for behaving (ever) :(

Merged to master as of 8019007766da1a09b0280d37ab9e5aa4df396e7f-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list