[Skiboot] [trivial PATCH] FSP/CONSOLE: Fix possible NULL dereference

Stewart Smith stewart at linux.vnet.ibm.com
Mon Jun 19 16:51:28 AEST 2017


Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:
> Fix coverity warning message.
>
> Null pointer dereferences  (NULL_RETURNS)
> /hw/fsp/fsp-console.c: 295 in fsp_open_vserial()
> 289
> 290             fs->open = true;
> 291
> 292             fs->poke_msg = fsp_mkmsg(FSP_CMD_VSERIAL_OUT, 2,
> 293                                      msg->data.words[0],
> 294                                      msg->data.words[1] & 0xffff);
>>>>     CID 145796:  Null pointer dereferences  (NULL_RETURNS)
>>>>     Dereferencing a null pointer "fs->poke_msg".
> 295             fs->poke_msg->user_data = fs;
> 296
> 297             fs->in_buf->partition_id = fs->out_buf->partition_id = part_id;
> 298             fs->in_buf->session_id   = fs->out_buf->session_id   = sess_id;
> 299             fs->in_buf->hmc_id       = fs->out_buf->hmc_id       = hmc_indx;
> 300             fs->in_buf->data_offset  = fs->out_buf->data_offset  =
>
> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>

Cheers, merged to master as of 5e55f0b5e0791eae54da39dfeff38f57a3dcbfa4
-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list