[Skiboot] [PATCH] hw/phb4: Rework phb4_get_presence_state()

Stewart Smith stewart at linux.vnet.ibm.com
Mon Jun 19 16:45:54 AEST 2017

Gavin Shan <gwshan at linux.vnet.ibm.com> writes:
> There are two issues in current implementation: It should return errcode
> visibile to Linux, which has prefix OPAL_*. The code isn't very obvious.
> This returns OPAL_HARDWARE when the PHB is broken. Otherwise, OPAL_SUCCESS
> is always returned. In the mean while, It refactors the code to make it
> obvious: OPAL_PCI_SLOT_PRESENT is returned when the presence signal (low active)
> or PCIe link is active. Otherwise, OPAL_PCI_SLOT_EMPTY is returned.
> Signed-off-by: Gavin Shan <gwshan at linux.vnet.ibm.com>
> ---
>  hw/phb4.c | 32 +++++++++++---------------------
>  1 file changed, 11 insertions(+), 21 deletions(-)

Thanks! Merged to master as of d065caf3b3101400744d4afb915edf57755a0c95

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list