[Skiboot] [PATCH v12 08/10] skiboot: Add opal call to enable/disable Nest IMC

[Madhavan Srinivasan]

On Wednesday 14 June 2017 10:29 AM, Michael Neuling wrote:
>> +	switch (type) {
>> +	case OPAL_IMC_COUNTERS_NEST:
>> +		/* Fetch the IMC control block structure */
>> +		cb = get_imc_cb();
>> +		status = be64_to_cpu(cb->imc_chip_run_status);
>> +
>> +		/* Check whether the engine is already running */
>> +		if (status == NEST_IMC_RUNNING)
>> +			return ret;
>> +
>> +		/* Set the run command */
>> +		op = NEST_IMC_ENABLE;
>> +
>> +		/* Write the command to the control block now */
>> +		cb->imc_chip_command = op;
> this needs a cpu_to_be(op)
Yes I did that when reading but missed it on the writing part.
Will add it.

Thanks for review
Maddy

>
> same with all the other imc_chip_commands here and the next patch.
>
> Mikey
>