[Skiboot] [PATCH v3] ipmi-sel: Rewrite dropped eSEL log message to fix various issues

Suraj Jitindar Singh sjitindarsingh at gmail.com
Fri Jun 16 15:43:50 AEST 2017


On Fri, 2017-06-16 at 15:04 +0930, Andrew Jeffery wrote:
> Surely this time.
> 
> Cc: Suraj Jitindar Singh <sjitindarsingh at gmail.com>
> Cc: Oliver O'Halloran <oohall at gmail.com>
> Cc: Russell Currey <ruscur at russell.cc>
> Cc: Joel Stanley <joel at jms.id.au>
> Signed-off-by: Andrew Jeffery <andrew at aj.id.au>
> ---
>  hw/ipmi/ipmi-sel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/ipmi/ipmi-sel.c b/hw/ipmi/ipmi-sel.c
> index 847604ec10bf..786f2132c57c 100644
> --- a/hw/ipmi/ipmi-sel.c
> +++ b/hw/ipmi/ipmi-sel.c
> @@ -335,7 +335,7 @@ static void ipmi_elog_poll(struct ipmi_msg *msg)
>  	size_t req_size;
>  
>  	if (bmc_platform->ipmi_oem_partial_add_esel == 0) {
> -		prlog(PR_WARNING, "BUG: Dropping ESEL on the floor
> due to buggy/mising code in OPAL for this BMC\n");
> +		prlog(PR_WARNING, "BUG: See
> https://pastebin.com/1HffsTgz");

What if my machine doesn't have an internet connection? I don't think
getting messages should be reliant on this.

>  		return;
>  	}
>  


More information about the Skiboot mailing list