[Skiboot] [PATCH v2] ipmi-sel: Fix missing typo, line length and correct eSEL stylisation

[Andrew Jeffery]

On Fri, 2017-06-16 at 14:54 +1000, Oliver wrote:
> > On Fri, Jun 16, 2017 at 2:42 PM, Andrew Jeffery <andrew at aj.id.au> wrote:
> > It might seem impossible to some that missing typos can be fixed
> > without being first added, but here we are. Further, reduce the line
> > length to sensible limits to ensure Joel provides a Reviewed-by, and
> > fix eSEL stylisation to hopefully extract similar tags from the rest of
> > the peanut gallery.
> > 
> > > > Suggested-by: Joel Stanley <joel at jms.id.au>
> > > > Suggested-by: Russell Currey <ruscur at russell.cc>
> > > > Signed-off-by: Andrew Jeffery <andrew at aj.id.au>
> > ---
> > 
> > What else have I missed?
> > 
> >  hw/ipmi/ipmi-sel.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/hw/ipmi/ipmi-sel.c b/hw/ipmi/ipmi-sel.c
> > index 847604ec10bf..5c766472b40c 100644
> > --- a/hw/ipmi/ipmi-sel.c
> > +++ b/hw/ipmi/ipmi-sel.c
> > @@ -335,7 +335,7 @@ static void ipmi_elog_poll(struct ipmi_msg *msg)
> >         size_t req_size;
> > 
> >         if (bmc_platform->ipmi_oem_partial_add_esel == 0) {
> > -               prlog(PR_WARNING, "BUG: Dropping ESEL on the floor due to buggy/mising code in OPAL for this BMC\n");
> > +               prlog(PR_WARNING, "Dropped eSEL: BMC code is buggy/missing\n");
> >                 return;
> 
> 
> Hmm, I don't think we should make error messages less descriptive just
> for the sake of 80 cols compliance.

It's totally an SNR increase. It really deserves an ack. You know it. I
know it. Lets do it.

> 
> >         }
> > 
> > --
> > 2.11.0
> > 
> > _______________________________________________
> > Skiboot mailing list
> > Skiboot at lists.ozlabs.org
> > https://lists.ozlabs.org/listinfo/skiboot
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/skiboot/attachments/20170616/d4a2f111/attachment.sig>