[Skiboot] [PATCH] ipmi-sel: fixing 'mising' typo

Andrew Jeffery andrew at aj.id.au
Fri Jun 16 14:22:42 AEST 2017


On Fri, 2017-06-16 at 14:08 +1000, Russell Currey wrote:
> On Fri, 2017-06-16 at 12:16 +0930, Andrew Jeffery wrote:
> > Signed-off-by: Andrew Jeffery <andrew at aj.id.au>
> 
> How can you fix a missing typo?  Isn't that called adding a typo?

Hilariously I just realised I wrote 'fixing' rather than 'Fix' (which I
intended) in the subject.

> 
> > ---
> >  hw/ipmi/ipmi-sel.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/hw/ipmi/ipmi-sel.c b/hw/ipmi/ipmi-sel.c
> > index 847604ec10bf..aab28664c3ff 100644
> > --- a/hw/ipmi/ipmi-sel.c
> > +++ b/hw/ipmi/ipmi-sel.c
> > @@ -335,7 +335,7 @@ static void ipmi_elog_poll(struct ipmi_msg *msg)
> > > >  	size_t req_size;
> >  
> > > >  	if (bmc_platform->ipmi_oem_partial_add_esel == 0) {
> > > > -		prlog(PR_WARNING, "BUG: Dropping ESEL on the floor due to
> > buggy/mising code in OPAL for this BMC\n");
> > > > +		prlog(PR_WARNING, "BUG: Dropping ESEL on the floor due to
> > buggy/missing code in OPAL for this BMC\n");
> 
> Since you need a new revision to address Joel's feedback, change ESEL to eSEL as
> it should be stylised.

I can't even find any other instances of 'ESEL' to argue my way out of
this. How annoying. v2 for a typo fix imminent. Sigh.

> 
> > > >  		return;
> > > >  	}
> >  
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/skiboot/attachments/20170616/4ee4e15f/attachment.sig>


More information about the Skiboot mailing list