[Skiboot] [PATCH] FSP: Set status field in response message for timed out message

Stewart Smith stewart at linux.vnet.ibm.com
Wed Jun 14 16:58:41 AEST 2017

Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:
> For timed out FSP messages, we set message status as "fsp_msg_timeout".
> But most FSP driver users (like surviellance) are ignoring this field.
> They always look for FSP returned status value in callback function
> (second byte in word1). So we endup treating timed out message as success
> response from FSP.
> Sample output:
> [69902.432509048,7] SURV: Sending the heartbeat command to FSP
> [70023.226860117,4] FSP: Response from FSP timed out, word0 = d66a00d7, word1 = 0 state: 3
> ....
> [70023.226901445,7] SURV: Received heartbeat acknowledge from FSP
> [70023.226903251,3] FSP: fsp_trigger_reset() entry
> Here SURV code thought it got valid response from FSP. But actually we didn't
> receive response from FSP.
> This patch fixes above issue by updating status field in response structure.
> CC: Ananth N Mavinakayanahalli <ananth at linux.vnet.ibm.com>
> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
> Acked-by: Ananth N Mavinakayanahalli <ananth at linux.vnet.ibm.com>

Thanks, merged to master as of 4cef4d8d6000936b1a4e1065bf69ee2edd3fcc1f
and to 5.4.x as of c7e1d072cc18088a5ba12779f5f11b97bb886723

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list