[Skiboot] [PATCH] FSP/RTC: Remove local fsp_in_reset variable
Vasant Hegde
hegdevasant at linux.vnet.ibm.com
Tue Jun 13 18:21:49 AEST 2017
Now that we are using fsp_in_rr() to detect FSP reset/reload, fsp_in_reset
become redundant. Lets remove this local variable.
Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
---
hw/fsp/fsp-rtc.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/hw/fsp/fsp-rtc.c b/hw/fsp/fsp-rtc.c
index 1de22e8..dbc2131 100644
--- a/hw/fsp/fsp-rtc.c
+++ b/hw/fsp/fsp-rtc.c
@@ -88,12 +88,6 @@ static enum {
static bool rtc_tod_cache_dirty = false;
-/* TODO We'd probably want to export and use this variable declared in fsp.c,
- * instead of each component individually maintaining the state.. may be for
- * later optimization
- */
-static bool fsp_in_reset = false;
-
struct opal_tpo_data {
uint64_t tpo_async_token;
uint32_t *year_month_day;
@@ -528,14 +522,10 @@ static bool fsp_rtc_msg_rr(u32 cmd_sub_mod, struct fsp_msg *msg)
switch (cmd_sub_mod) {
case FSP_RESET_START:
- lock(&rtc_lock);
- fsp_in_reset = true;
- unlock(&rtc_lock);
rc = true;
break;
case FSP_RELOAD_COMPLETE:
lock(&rtc_lock);
- fsp_in_reset = false;
if (rtc_tod_cache_dirty) {
rtc_flush_cached_tod();
rtc_tod_cache_dirty = false;
--
2.9.3
More information about the Skiboot
mailing list