[Skiboot] [PATCH v12 05/10] skiboot: Nest IMC macro definitions

Michael Neuling mikey at neuling.org
Tue Jun 13 16:36:30 AEST 2017

On Sun, 2017-05-21 at 20:40 +0530, Madhavan Srinivasan wrote:
> > From: Hemant Kumar <hemant at linux.vnet.ibm.com>
> Add the macros needed for Nest IMC (In Memory Collection)
> instrumentation support by creating a new file in include/ called
> "imc.h". Also, add a header "nest_imc.h" containing an array of
> possible list of nest PMUs. These macros are needed to discover the
> catalog subpartition, enable and disable the nest IMC instrumentation.
> > Signed-off-by: Hemant Kumar <hemant at linux.vnet.ibm.com>
> > Reviewed-by: Oliver O'Halloran <oohall at gmail.com>
> > Signed-off-by: Anju T Sudhakar <anju at linux.vnet.ibm.com>
> [maddy: Removed nest_imc.h and updated few macros]
> Signed-off-by: Madhavan Srinivasan <maddy at linux.vnet.ibm.com>

A couple of minor nits below but....

Acked-by: Michael Neuling <mikey at neuling.org>

> +/*
> + * In-Memory Collection (IMC) Counters :
> + * Power9 has IMC instrumentation support with which several
> + * metrics of the  platform can be monitored. These metrics

double space

s/the  platform/the platform"

> + * are backed by the Performance Monitoring Units (PMUs) and
> + * their counters. IMC counters can be configured to run
> + * continuously from startup to shutdow and data from these


More information about the Skiboot mailing list