[Skiboot] [PATCH v2] phb4: Activate shared PCI slot on witherspoon

Michael Neuling mikey at neuling.org
Tue Jun 6 11:45:22 AEST 2017


> +	 * Plugging a x8 or less adapter on the shared slot should work
> +	 * like any other physical slot.
> +	 */
> +	chip0 = next_chip(NULL);
> +	slot0 = pci_slot_find(get_opal_id(chip0->id, 3));
> +	chip1 = next_chip(chip0);
> +	slot1 = pci_slot_find(get_opal_id(chip1->id, 3));

I think you need to NULL check chip1 here.  If you boot on a single chip system
I think you'll crash here.  

Mikey


More information about the Skiboot mailing list