[Skiboot] [PATCH v2 13/19] external/pflash: Move write and read size calculation together
Cyril Bur
cyril.bur at au1.ibm.com
Fri Jul 28 16:46:31 AEST 2017
Very simple rework, makes sense to calculate those at the same time.
Signed-off-by: Cyril Bur <cyril.bur at au1.ibm.com>
---
external/pflash/pflash.c | 24 +++++++++++-------------
1 file changed, 11 insertions(+), 13 deletions(-)
diff --git a/external/pflash/pflash.c b/external/pflash/pflash.c
index c0d96863..e917a2a5 100644
--- a/external/pflash/pflash.c
+++ b/external/pflash/pflash.c
@@ -884,19 +884,6 @@ int main(int argc, char *argv[])
goto out;
}
- /* If file specified but not size, get size from file
- */
- if (write_file && !write_size) {
- struct stat stbuf;
-
- if (stat(write_file, &stbuf)) {
- perror("Failed to get file size");
- rc = 1;
- goto out;
- }
- write_size = stbuf.st_size;
- }
-
if (tune && !direct) {
fprintf(stderr, "It doesn't make sense to --tune without --direct\n");
rc = 1;
@@ -937,6 +924,17 @@ int main(int argc, char *argv[])
goto out;
}
+ /* If file specified but not size, get size from file */
+ if (write_file && !write_size) {
+ struct stat stbuf;
+
+ if (stat(write_file, &stbuf)) {
+ perror("Failed to get file size");
+ rc = 1;
+ goto out;
+ }
+ write_size = stbuf.st_size;
+ }
/* If read specified and no read_size, use flash size */
if (do_read && !read_size && !part_name)
--
2.13.3
More information about the Skiboot
mailing list