[Skiboot] [PATCH] FSP/CONSOLE: Do not enable input irq in write path

Stewart Smith stewart at linux.vnet.ibm.com
Tue Jul 25 18:18:16 AEST 2017

Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:
> We use irq for reading input from console, but not in output path.
> Hence do not enable input irq in write path.
> Fixes : 583c8203 (fsp/console: Allocate irq for each hvc console)
> CC: Sam Mendoza-Jonas <sam at mendozajonas.com>
> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>

Thanks, merged to master as of 72aa080d0970f7757ccf4f3b00096f2f8bbcafde.

I also now have a test case that seems independent of skiboot version,
where you can get a soft lockup in kopald on recent kernels.. This seems
to be limited to when you exit petitboot and go for a fast reboot
*really* soon after booting. I can usually reproduce within 5
fast-reboots, but sometimes takes as much as 10.

I'm pretty convinced that this is a kernel issue.. or at least not a
*regression* on the skiboot side since our service pack stream.

So, I think we should get to the bottom of that before I necessarily
backport this fix to 5.4.x?

Ideally, it's probably about time some time is spent on getting that
giant test matrix for these things automated....

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list