[Skiboot] [PATCH 04/10] phb4: Change timeouts prints to error level

Michael Neuling mikey at neuling.org
Thu Jul 20 16:22:14 AEST 2017


If the link doesn't have a electrical link or the link doesn't train
we should make that more obvious to the user.

This boosts these prints to error level.

Signed-off-by: Michael Neuling <mikey at neuling.org>
---
 hw/phb4.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/phb4.c b/hw/phb4.c
index 48c591f4f3..cf9ee61871 100644
--- a/hw/phb4.c
+++ b/hw/phb4.c
@@ -2218,7 +2218,7 @@ static int64_t phb4_poll_link(struct pci_slot *slot)
 		}
 
 		if (slot->retries-- == 0) {
-			PHBDBG(p, "LINK: Timeout waiting for electrical link\n");
+			PHBERR(p, "LINK: Timeout waiting for electrical link\n");
 			PHBDBG(p, "LINK: DLP train control: 0x%016llx\n", reg);
 			rc = phb4_retry_state(slot);
 			if (rc >= OPAL_SUCCESS)
@@ -2239,7 +2239,7 @@ static int64_t phb4_poll_link(struct pci_slot *slot)
 		}
 
 		if (slot->retries-- == 0) {
-			PHBDBG(p, "LINK: Timeout waiting for link up\n");
+			PHBERR(p, "LINK: Timeout waiting for link up\n");
 			PHBDBG(p, "LINK: DLP train control: 0x%016llx\n", reg);
 			rc = phb4_retry_state(slot);
 			if (rc >= OPAL_SUCCESS)
-- 
2.11.0



More information about the Skiboot mailing list