[Skiboot] [PATCH] platform/witherspoon: Enable eSEL logging

[Stewart Smith]

Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:
>>> --- a/platforms/astbmc/witherspoon.c
>>> +++ b/platforms/astbmc/witherspoon.c
>>> @@ -410,7 +410,7 @@ DECLARE_PLATFORM(witherspoon_platform) = {
>>>  	.pre_pci_fixup		= witherspoon_pre_pci_fixup,
>>>  	.start_preload_resource	= flash_start_preload_resource,
>>>  	.resource_loaded	= flash_resource_loaded,
>>> -	.bmc			= NULL, /* FIXME: Add openBMC */
>>> +	.bmc			= &astbmc_ami,
>>
>> I'd prefer to have an astbmc_openbmc type that would populate data
>> accordingly.
>>
>> Otherwise, with this patch, on boot, we'd get a notification for
>> witherspoon that the BMC type is "AMI", which is (of course) incorrect.
>>
>
> Stewart,
>
> Agree. Something like below looks good?
>
> +++ b/platforms/astbmc/common.c
> @@ -414,3 +414,9 @@ const struct bmc_platform astbmc_ami = {
>          .ipmi_oem_partial_add_esel   = IPMI_CODE(0x32, 0xf0),
>          .ipmi_oem_pnor_access_status = IPMI_CODE(0x3a, 0x07),
>   };
> +
> +const struct bmc_platform astbmc_openbmc = {
> +       .name = "OpenBMC",
> +       .ipmi_oem_partial_add_esel   = IPMI_CODE(0x32, 0xf0),
> +       .ipmi_oem_pnor_access_status = IPMI_CODE(0x3a, 0x07),
> +};

Yeah, looks good - but are those values documented anywhere for OpenBMC?

It may be good to point to the docs in the commit message

-- 
Stewart Smith
OPAL Architect, IBM.