[Skiboot] [PATCH] platform/witherspoon: Enable eSEL logging

Stewart Smith stewart at linux.vnet.ibm.com
Mon Jul 17 12:00:01 AEST 2017


Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:
> OpenBMC stack added IPMI OEM extension to log eSEL events.
> Lets enable eSEL logging from OPAL side.
>
> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
> ---
>  platforms/astbmc/witherspoon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/platforms/astbmc/witherspoon.c b/platforms/astbmc/witherspoon.c
> index 6a77306..13c072f 100644
> --- a/platforms/astbmc/witherspoon.c
> +++ b/platforms/astbmc/witherspoon.c
> @@ -410,7 +410,7 @@ DECLARE_PLATFORM(witherspoon_platform) = {
>  	.pre_pci_fixup		= witherspoon_pre_pci_fixup,
>  	.start_preload_resource	= flash_start_preload_resource,
>  	.resource_loaded	= flash_resource_loaded,
> -	.bmc			= NULL, /* FIXME: Add openBMC */
> +	.bmc			= &astbmc_ami,

I'd prefer to have an astbmc_openbmc type that would populate data
accordingly.

Otherwise, with this patch, on boot, we'd get a notification for
witherspoon that the BMC type is "AMI", which is (of course) incorrect.

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list