[Skiboot] [PATCH] core/hmi.c: Don't attempt to decode malfunction alerts for unsupported chips
stewart at linux.vnet.ibm.com
Wed Jul 12 15:00:42 AEST 2017
Mahesh Jagannath Salgaonkar <mahesh at linux.vnet.ibm.com> writes:
> On 07/06/2017 10:50 AM, Alistair Popple wrote:
>> Currently decode_malfunction() attempts to decode HMI events by looking at xscom
>> registers which are specific to P8. Obviously this doesn't work on P9 as many of
>> these addresses and HW interfaces have changed which results in further HMI
>> events due to invalid SCOM addresses accesses. Until decode_malfunction()
>> understands how to decode P9 HMI events it is better to just bail with an
>> unknown HMI event which will ultimately cause the OS to request a reboot.
> The patches posted below already fixes this.
I've now taken these patches.
Although the idea of guarding the HMI handling with a check that we
actually support it isn't a bad one, it's just that this patch no longer
Alistair, able to respin?
OPAL Architect, IBM.
More information about the Skiboot