[Skiboot] [PATCH 4/9] cpu: Better handle unknown flags in opal_reinit_cpus()
stewart at linux.vnet.ibm.com
Wed Jul 12 13:20:26 AEST 2017
Benjamin Herrenschmidt <benh at kernel.crashing.org> writes:
> At the moment, if we get passed flags we don't know about, we
> return OPAL_UNSUPPORTED but we still perform whatever actions
> was requied by the flags we do support. Additionally, on P8,
> we attempt a SLW re-init which hasn't been supported since
> Murano DD2.0 and will crash your system.
> It's too late to fix on existing systems so Linux will have to
> be careful at least on P8, but to avoid future issues let's clean
> that up, make sure we only use slw_reinit() when HILE isn't
> supported and don't return OPAL_UNSUPPORTED at all.
> Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>
I kept the OPAL_UNSUPPORTED, even though we don't (currently) check it
anywhere in Linux, and merged to master as of
OPAL Architect, IBM.
More information about the Skiboot