[Skiboot] [PATCH 16/16] phb4: Do more retries on link training failures

Michael Neuling mikey at neuling.org
Wed Jul 12 12:06:55 AEST 2017


Currently we only retry once when we have a link training failure.

This changes this to be 3 retries as 1 retry is not giving us enough
reliablity.

This will increase the boot time, especially on systems where we
incorrectly detect a link presence when there really is nothing
present. I'll post a followup patch to optimise our timings to help
mitigate this later.

Signed-off-by: Michael Neuling <mikey at neuling.org>
---
 hw/phb4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/phb4.c b/hw/phb4.c
index 041c626601..2f3af3aec8 100644
--- a/hw/phb4.c
+++ b/hw/phb4.c
@@ -2512,7 +2512,7 @@ static struct pci_slot *phb4_slot_create(struct phb *phb)
 	slot->ops.hreset		= phb4_hreset;
 	slot->ops.freset		= phb4_freset;
 	slot->ops.creset		= phb4_creset;
-	slot->link_retries		= 1;
+	slot->link_retries		= 3;
 
 	return slot;
 }
-- 
2.11.0



More information about the Skiboot mailing list