[Skiboot] [PATCH 08/16] phb4: Remove incorrect state transition

Michael Neuling mikey at neuling.org
Wed Jul 12 12:06:47 AEST 2017

When waiting in PHB4_SLOT_CRESET_WAIT_CQ for transations to end, we
incorrectly move onto the next state.  Generally we don't hit this as
the transactions have ended already anyway.

This removes the incorrect state transition.

Signed-off-by: Michael Neuling <mikey at neuling.org>
 hw/phb4.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/phb4.c b/hw/phb4.c
index 1d10bb88ad..088ca9643e 100644
--- a/hw/phb4.c
+++ b/hw/phb4.c
@@ -2455,7 +2455,6 @@ static int64_t phb4_creset(struct pci_slot *slot)
 			PHBERR(p, "Timeout waiting for pending transaction\n");
 			goto error;
-		pci_slot_set_state(slot, PHB4_SLOT_CRESET_REINIT);
 		return pci_slot_set_sm_timeout(slot, msecs_to_tb(100));
 		PHBDBG(p, "CRESET: Reinitialization\n");

More information about the Skiboot mailing list