[Skiboot] [PATCH] core/hmi.c: Don't attempt to decode malfunction alerts for unsupported chips

Andrew Donnellan andrew.donnellan at au1.ibm.com
Thu Jul 6 16:00:27 AEST 2017


On 06/07/17 15:20, Alistair Popple wrote:
> Currently decode_malfunction() attempts to decode HMI events by looking at xscom
> registers which are specific to P8. Obviously this doesn't work on P9 as many of
> these addresses and HW interfaces have changed which results in further HMI
> events due to invalid SCOM addresses accesses. Until decode_malfunction()
> understands how to decode P9 HMI events it is better to just bail with an
> unknown HMI event which will ultimately cause the OS to request a reboot.
>
> Signed-off-by: Alistair Popple <alistair at popple.id.au>

We obviously need to fix this properly at some point, but in the interim...

Reviewed-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited



More information about the Skiboot mailing list