[Skiboot] [PATCH] phb4: Fix number of index bits in IODA tables

Michael Neuling mikey at neuling.org
Sat Jul 1 01:09:25 AEST 2017


On Tue, 2017-06-27 at 10:27 -0500, Benjamin Herrenschmidt wrote:
> On PHB4 the number of index bits in the IODA table address register
> was bumped to 10 bits to accomodate for 1024 MSIs and 1024 TVEs (DD2).
> 
> However our macro only defined the field to be 9 bits, thus causing
> "interesting" behaviours on some systems.
> 
> Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>

Acked-by: Michael Neuling <mikey at neuling.org>

> ---
>  include/phb4-regs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/phb4-regs.h b/include/phb4-regs.h
> index d22acf4..14e9351 100644
> --- a/include/phb4-regs.h
> +++ b/include/phb4-regs.h
> @@ -97,7 +97,7 @@
>  #define   PHB_IODA_AD_AUTOINC		PPC_BIT(0)
>  #define	  PHB_IODA_AD_TSEL		PPC_BITMASK(11,15)
>  #define	  PHB_IODA_AD_MIST_PWV		PPC_BITMASK(28,31)
> -#define	  PHB_IODA_AD_TADR		PPC_BITMASK(55,63)
> +#define	  PHB_IODA_AD_TADR		PPC_BITMASK(54,63)
>  #define PHB_IODA_DATA0			0x228
>  #define PHB_FFI_REQUEST			0x238
>  #define   PHB_FFI_LOCK_CLEAR		PPC_BIT(3)
> 
> 
> _______________________________________________
> Skiboot mailing list
> Skiboot at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/skiboot


More information about the Skiboot mailing list