[Skiboot] [RFC PATCH 1/2] libflash/blocklevel: Optionally always return opal-api return codes

[Benjamin Herrenschmidt]

On Wed, 2017-01-25 at 18:56 +1100, Cyril Bur wrote:
> +int check_rc(struct blocklevel_device *bl, int rc)
> +{
> +       if (!(bl->flags & OPAL_RETURN_CODE_ONLY) || rc < 1)
> +               return rc;
> +
> +       switch (rc) {
> +               case FLASH_ERR_MALLOC_FAILED:
> +               return OPAL_NO_MEM;
> +
> +               case FLASH_ERR_CHIP_UNKNOWN:
> +               return OPAL_HARDWARE;
> +
> +               case FLASH_ERR_PARM_ERROR:
> +               return OPAL_PARAMETER;
> +
> +               case FLASH_ERR_ERASE_BOUNDARY:
> +               return OPAL_UNSUPPORTED; /* or just OPAL_PARAMETER?
> */
> +
> +               case FLASH_ERR_WREN_TIMEOUT:
> +               case FLASH_ERR_WIP_TIMEOUT:
> +               case FLASH_ERR_VERIFY_FAILURE:
> +               return OPAL_INTERNAL_ERROR;
> +
> +               case FLASH_ERR_4B_NOT_SUPPORTED:
> +               return OPAL_UNSUPPORTED;
> +
> +               case FLASH_ERR_CTRL_CONFIG_MISMATCH:
> +               return OPAL_INTERNAL_ERROR;
> +
> +               case FLASH_ERR_CHIP_ER_NOT_SUPPORTED:
> +               case FLASH_ERR_CTRL_CMD_UNSUPPORTED:
> +               return OPAL_UNSUPPORTED;
> +
> +               case FLASH_ERR_CTRL_TIMEOUT:
> +               case FLASH_ERR_ECC_INVALID:
> +               case FLASH_ERR_BAD_READ:
> +               return OPAL_INTERNAL_ERROR;
> +       }


I would prefer if we created a chunck of OPAL error mapping the
blocklevel errors....

We are losing information here.

Cheers,
Ben.