[Skiboot] [PATCH] platform: set default bmc_platform

Stewart Smith stewart at linux.vnet.ibm.com
Mon Jan 16 13:38:31 AEDT 2017


Oliver O'Halloran <oohall at gmail.com> writes:
> The bmc_platform pointer is set to NULL by default and on non-AMI BMC
> platforms. As a result a few places in hw/ipmi/ipmi-sel.c will blindly
> dereference a NULL pointer.
>
> This patch sets the default value for bmc_platform to generic_bmc to
> avoid this.
>
> Signed-off-by: Oliver O'Halloran <oohall at gmail.com>
> ---
>  core/platform.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Thanks! I was casually sure I dealt with this case when I first wrote
it... but perhaps I didn't, and I can't remember a reason why I wouldn't
have.

So, well, merged to master as of e0f184b6eaf9e302cd1366042d37d7af968e38e9

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list