[Skiboot] [PATCH 0/5] CAPI disabling support for kexec/fast reboot

[Frederic Barrat]

Le 13/01/2017 à 05:21, Andrew Donnellan a écrit :
> On 13/01/17 00:25, Frederic Barrat wrote:
>> I had a look at the series and it's pretty interesting.
>> Nothing to complain about, just one question: why do we have to keep the
>> capp recovery separate from disabling capi mode? I'm guessing it has to
>> do with the interactions between the capp and phb and the phb being
>> fenced, but would appreciate if you have some details.
>
> Thanks for reviewing!
>
> Doing the CAPP recovery sequence before the rest of the disable sequence
> causes a checkstop, I'm not exactly sure why.
>

Could we do it immediately at the end of disable_capi_mode() and not 
bother with the PHB3_CAPP_DISABLING flag?

   Fred