[Skiboot] [RFC PATCH 1/3] hw/lpc-mbox: Add skiboot drivers for the BMC mbox regs

Benjamin Herrenschmidt benh at kernel.crashing.org
Sat Jan 14 02:58:39 AEDT 2017

On Fri, 2017-01-13 at 13:42 +1100, Joel Stanley wrote:
> > +void ast_setup_sio_mbox(uint16_t io_base, uint8_t irq)
> > +{
> > +       bmc_sio_get(BMC_SIO_DEV_MBOX);
> This function is the same as setup_sio_uart1 except for this line.
> You
> could send a follow up to combine them.

Not that fan of that. The fact that the register offset happen to
be the same for the mbox and the uart is more like an accident..

They are different for other SIO devices no ?


More information about the Skiboot mailing list