[Skiboot] [PATCH] hdata: Fix ibm,pa-features for all CPU types

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Thu Jan 12 21:21:25 AEDT 2017


On 01/12/2017 09:40 AM, Russell Currey wrote:
> On Wed, 2017-01-11 at 17:33 -0600, Benjamin Herrenschmidt wrote:
>> Hopefully the values are all right ;-) A future TODO is to
>> use some nice macro to make it clearer who is what.
>>
>> Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>
>> ---
>
> This patch fails a test (found by snowpatch):
>
> In file included from hdata/test/hdata_to_dt.c:92:0:
> hdata/test/../cpu-common.c: In function "add_core_common":
> hdata/test/../cpu-common.c:102:3: error: implicit declaration of function
> "PVR_VERS_MAJ" [-Werror=implicit-function-declaration]
>     if (PVR_VERS_MAJ(version) == 1) {
>     ^
> cc1: all warnings being treated as errors
> make: *** [hdata/test/hdata_to_dt] Error 1
>
> Not sure about this one, given cpu-common.c includes cpu.h which includes
> processor.h which defines PVR_VERS_MAJ.

Thats because we have defined PROCESSOR_H in hdata_to_dt.c

52 #define __PROCESSOR_H

May be we should add dummy PVR_VERS_MAJ in this file.

-Vasant



More information about the Skiboot mailing list