[Skiboot] [PATCH 04/14] hdat: create XIVE nodes under each xscom node

[Oliver O'Halloran]

On Thu, Jan 12, 2017 at 5:41 PM, Vasant Hegde
<hegdevasant at linux.vnet.ibm.com> wrote:
> On 01/12/2017 09:24 AM, Oliver O'Halloran wrote:
>>
>> Adds the XIVE node under each chip's XSCOM controller node.
>>
>> Signed-off-by: Oliver O'Halloran <oohall at gmail.com>
>> ---
>>   hdata/spira.c | 14 ++++++++++++++
>>   1 file changed, 14 insertions(+)
>>
>> diff --git a/hdata/spira.c b/hdata/spira.c
>> index 5c122398cc2e..58278c90a90e 100644
>> --- a/hdata/spira.c
>> +++ b/hdata/spira.c
>> @@ -333,6 +333,17 @@ static void add_psihb_node(struct dt_node *np)
>>         }
>>   }
>>
>> +static void add_xive_node(struct dt_node *np)
>> +{
>> +       struct dt_node *xive = dt_new_addr(np, "xive", 0x5013000);
>
>
> You may want to add comment for this magic number. Otherwise we have to open
> spec and understand from where this magic number is coming from.

Honestly there's not much that can be said about it. It's the just the
start of the XIVE XSCOM registers. I thought that was reasonably clear
since it's a unit address under the XSCOM node. Maybe I've spent too
much time looking at device trees...