[Skiboot] [PATCH] phb4: The "AB detect" mechanism doesn't exist anymore

[Oliver O'Halloran]

On Mon, Jan 9, 2017 at 10:30 AM, Benjamin Herrenschmidt
<benh at kernel.crashing.org> wrote:
> Remove the code copying the property around and the corresponding
> HDAT code.
>
> Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>
> ---
>  hdata/iohub.c | 10 ----------
>  hw/phb4.c     |  2 --
>  2 files changed, 12 deletions(-)
>
> diff --git a/hdata/iohub.c b/hdata/iohub.c
> index 192e8cf..d40f644 100644
> --- a/hdata/iohub.c
> +++ b/hdata/iohub.c
> @@ -281,16 +281,6 @@ static struct dt_node *add_pec_stack(const struct cechub_io_hub *hub,
>
>         __dt_add_property_u64s(stack, "ibm,lane-eq", 8, eq);
>
> -       /* We indicate that this is an IBM setup, which means that
> -        * the presence detect A/B bits are meaningful. So far we
> -        * don't know whether they make any sense on customer setups
> -        * so we only set that when booting with HDAT
> -        *
> -        * XXX: Since we have HDAT in P9 OpenPower boxes
> -        *      is this still going to be true?
> -        */
> -       dt_add_property(stack, "ibm,use-ab-detect", NULL, 0);
> -
>         return stack;
>  }
>
> diff --git a/hw/phb4.c b/hw/phb4.c
> index 981c16d..77b5f07 100644
> --- a/hw/phb4.c
> +++ b/hw/phb4.c
> @@ -3442,8 +3442,6 @@ static void phb4_probe_stack(struct dt_node *stk_node, uint32_t pec_index,
>         dt_add_property_cells(np, "ibm,phb-stack", stk_node->phandle);
>         dt_add_property_cells(np, "ibm,phb-stack-index", stk_index);
>         dt_add_property_cells(np, "ibm,chip-id", gcid);
> -       if (dt_has_node_property(stk_node, "ibm,use-ab-detect", NULL))
> -               dt_add_property(np, "ibm,use-ab-detect", NULL, 0);
>         if (dt_has_node_property(stk_node, "ibm,hub-id", NULL))
>                 dt_add_property_cells(np, "ibm,hub-id",
>                                       dt_prop_get_u32(stk_node, "ibm,hub-id"));

The patch this is based on top of isn't in master. I've folded this
into my patch and I'll post that in a series later today/tomorrow.