[Skiboot] [PATCH v2 03/12] hdat: Add new fields to IPL params structure

[Vasant Hegde]

On 11/07/2016 11:15 AM, Oliver O'Halloran wrote:
> On Thu, Nov 3, 2016 at 4:49 PM, Vasant Hegde
> <hegdevasant at linux.vnet.ibm.com> wrote:
>> On 11/02/2016 09:18 AM, Oliver O'Halloran wrote:
>>>
>>> Is there any reason you're keying this off the processor generation
>>> rather than the HDIF structure version?
>>
>> Spec says these fields are implemented from HDAT v0x60.. But many cases its
>> not implemented on that version.. My understanding in all HDAT on P9 onwards
>> will have this field enabled. Anyway we don't care this field on P8.
>
> What version of the spec are you reading? 10.3g specs says the HDIF
> version for that struct is 0x70 in 910, not 0x60. The only fields that
> depends on 0x60 are the TPM fields.

I was referring to individual fields inside the structure.  We can check for 
HDIF version number as well (as we expect all these fields to be populated from 
0x70).

>
>>
>> Hence instead of relying on HDAT version I used processor generation.
>>
>>> Currently hostboot doesn't
>>>
>>> populate the type strings (and leaves the struct version on 0x51 as a
>>> result), but it will set the sys_type field correctly. We should
>>> always use the sys_type test in the else case if the strings aren't
>>
>>
>> But they are suppose to implement this field at least on P9 !
>
> There are two distinct HDAT generators that we need to support, one
> from the FSP and one from hostboot. This patch works with the FSP
> build since they populate the strings (without incrementing the
> version number, but that's there bug to fix). However, it doesn't work
> with the standalone hostboot since they don't populate the strings
> yet. We can't rely on all P9 platforms having the same behaviour,
> especially at this stage of development.

But if we stick to processor generation it will work fine right?

-Vasant